Suggestion : two patches

Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #33753
    Iruau
    Participant

    Hello,

    First off, a translation patch : in French, all programs (including Windows itself) use the word “Réessayer” rather than “Retenter” as a translation to “Retry”.
    File ResFrenchsStrings.rc :

    CODE
    Index: sStrings.rc
    ===================================================================
    — sStrings.rc    (revision 255)
    +++ sStrings.rc    (working copy)
    @@ -14,7 +14,7 @@
       s_MsgDlgHelpNone, “Pas d'aide”
       s_MsgDlgHelpHelp, “Aide”
       s_MsgDlgAbort, “&Abandonner”
    –  s_MsgDlgRetry, “&Retenter”
    +  s_MsgDlgRetry, “&Réessayer”
       s_MsgDlgIgnore, “&Ignorer”
       s_MsgDlgAll, “&Tous”
       s_MsgDlgNoToAll, “N&on а tous”

    Second patch, only a wish of mine : currently AlphaHints are limited in width to 120 px for no apparent reason, which makes long hints use multiple lines unnecessarily.
    My proposed change is to limit the width of the hints to the user's screen width instead :

    CODE
    Index: acAlphaHints.pas
    ===================================================================
    — acAlphaHints.pas    (revision 254)
    +++ acAlphaHints.pas    (working copy)
    @@ -585,7 +585,7 @@
           Result := Rect(0, 0, HintFrame.Width, HintFrame.Height);
         end
         else begin
    –      Result := Rect(0, 0, 120{Manager.HintKind.FMaxWidth}, 0);
    +      Result := Rect(0, 0, Screen.Width{Manager.HintKind.FMaxWidth}, 0);
       {$IFNDEF ACHINTS}
           if Manager.Skinned then Manager.FCacheBmp.Canvas.Font.Assign(Screen.HintFont);
       {$ENDIF}

    As far as I am concerned, if you decide not to include those modifications it won't change anything for me (as I already apply them to each upgrade) but I believe it would be better defaults for everyone, hence my proposal.

    Have a nice day.

    #42623
    Support
    Keymaster

    Hello!

    I think that I will have a problem with recompiling of resources because some your characters are not exists in my system.
    Could you change Rc file, recompile it and send me these files?
    Command for compilation : brcc32 sStrings.rc sStrings.res

    About hints, I'll try to change sources in the nearest release already.

    #42624
    Iruau
    Participant

    Hi,

    While I was at it I also modified a few strings that I didn't notice the first time :

    CODE
    Index: sStrings.rc
    ===================================================================
    — sStrings.rc    (revision 255)
    +++ sStrings.rc    (working copy)
    @@ -14,7 +14,7 @@
       s_MsgDlgHelpNone, “Pas d'aide”
       s_MsgDlgHelpHelp, “Aide”
       s_MsgDlgAbort, “&Abandonner”
    –  s_MsgDlgRetry, “&Retenter”
    +  s_MsgDlgRetry, “&Réessayer”
       s_MsgDlgIgnore, “&Ignorer”
       s_MsgDlgAll, “&Tous”
       s_MsgDlgNoToAll, “N&on à tous”
    @@ -23,17 +23,17 @@
       s_RestoreStr, “Restaurer”
       s_MoveStr, “Déplacer”
       s_SizeStr, “Taille”
    –  s_MinimizeStr, “Minimiser”
    –  s_MaximizeStr, “Maximiser”
    +  s_MinimizeStr, “Réduire”
    +  s_MaximizeStr, “Agrandir”
       s_CloseStr, “Fermer”

       s_HintClose, “Fermer”
    –  s_HintMaximize, “Maximiser”
    –  s_HintMinimize, “Minimiser”
    +  s_HintMaximize, “Agrandir”
    +  s_HintMinimize, “Réduire”
       s_HintRestore, “Restaurer”
       s_HintHelp, “Aide”

    –  s_FileOpen, “Ouvrir fichier”
    +  s_FileOpen, “Ouvrir le fichier”

       s_Calculator, “Calculer”
       s_GradBuilder, “&Éditeur de dégradé…”
    @@ -93,7 +93,7 @@
       s_Folder, “Dossier”
       s_FileName, “Nom du fichier”
       s_FileType, “Type de fichier”
    –  s_ReadOnly, “Lecture seul”
    +  s_ReadOnly, “Lecture seule”
       s_ViewStyleList, “Liste”
       s_ViewStyleReport, “Détails”
       s_ViewStyleIcons, “Icônes”

    And by the way, recompiling the .res file didn't work out of the box : somewhere between versions 6.45 (excluded) and 6.58 (included), a bunch of identifiers disappeared from sStrings.pas but the .rc files still have a reference to those. I took the easy (lazy) way and just checked out sStrings.pas version 6.45 from my own SVN, but I guess this is not ideal (all the .rc files should be updated by deleting the now useless identifiers/translations). Anyway, here are the corrected French resources, coherent with the other translations (ie. including the now missing identifiers) :
    [attachment=3970:Res_French.zip]

    Keep up the good work!

    #42638
    Support
    Keymaster

    Thank you!

    #42692
    HeDiBo
    Participant

    QUOTE (Iruau @ May 17 2010, 09:25 AM) <{POST_SNAPBACK}>
    currently AlphaHints are limited in width to 120 px for no apparent reason, which makes long hints use multiple lines unnecessarily.
    My proposed change is to limit the width of the hints to the user's screen width instead


    I would like the hints to stay as they are: if only for compatibility reasons.
    I propose a new property: MaxHintWidth with 120 as the default value, and 0 meaning width of user screen.

    #42854
    IPSteven
    Participant

    QUOTE (HeDiBo @ May 31 2010, 07:54 AM) <{POST_SNAPBACK}>
    I would like the hints to stay as they are: if only for compatibility reasons.
    I propose a new property: MaxHintWidth with 120 as the default value, and 0 meaning width of user screen.

    I personally find hints the width of the screen very hard to read, especially at high screen resolutions.

    +1 to HeDiBo's suggestion.

    #42895
    Support
    Keymaster

    Hello
    Thanks Hedibo for suggestion, this property is available already.

    Author
    Posts
Viewing 7 posts - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.