[HeDiBo]

The internal skin info in TStoredSkin has properties Version, Author and Description.

But none of them are filled

[Support]

I will check and solve it.

[HeDiBo]

'Support' wrote:

I will check and solve it.

It's not solved in 14.05.

The new InternalSkins editor looks silly now, with the Version set to 0 for all internal skins

[HeDiBo]

I understand now that I have to add all internal skins afresh.

That's understandable. It's a surprise though to see these version 0 info's.

So, the Update All button might be a good place to add the missing info to the internal skins.

[HeDiBo]

Bugfix: in countries where the decimal point is a comma, the conversion of the version string to real fails.

You should provide a local formatstring to convert always with the decimal point.

So, in my case this statement gives a conversion error

Code:

SkinManager.InternalSkins[SkinManager.InternalSkins.Count – 1].Version := StrToFloat(TempSkinFile.ReadString(s_GlobalInfo, s_Version, '0'));

Because this Version property has never been used before (it was always 0) it would be better to take this opportunity to make it a string property.

[Support]

I will try to fix it in the nearest release.

[HeDiBo]

'Support' wrote:

I will try to fix it in the nearest release.

Try to set the version info too when the Update All button is clicked.

[Support]

I will try to do it in the v14.06

[HeDiBo]

'Support' wrote:

I will try to do it in the v14.06

It's not fixed at all in 14.06

To ensure you understand the severity of this: in this version of AC I cannot add any internal skin or refresh them.

I found there are three places in sInternalSkins.pas where this problem occurs.

Again: switch to a string representation of the version. That makes it compatible with the the other occurrence of the version property, allowing constructs like '13.05A'.

[Support]

I'm sorry for the error, please try the attached file.

Whole package will be updated at the nearest days.

[HeDiBo]

'Support' wrote:

I'm sorry for the error, please try the attached file.

Whole package will be updated at the nearest days.

Thanks.

I'm not seeing a switch to using the internal skin version as a string. That would make it compatible with the skinmanager's skin version.

There's no chance developers will get into trouble because the version of internal skins never worked before, so no one will have been using it.

[HeDiBo]

Do you hesitate to change the version property to a string?

It's still a float in 14.07

[Support]

Hello

Version of skins is used in the package as real value for comparison of old and new skins, I'm keeping it as real value because it's more handy for me.

[Author]

Posts