- This topic has 12 replies, 2 voices, and was last updated 6 years, 6 months ago by
HeDiBo.
-
AuthorPosts
-
June 14, 2018 at 2:22 pm #37872
HeDiBo
ParticipantThere are several skins where it is hardly discernible whether a TsComboBox or a TsCheckBox has focus.
This is a project to show that: [attachment=8797:acSetFocus.zip]
Try to tab to the top TsComboBox or one of the TsCheckBoxes below it. In the default skin (Notes Wood) it is hardly visible that one of these controls has focus. Then switch to a dark skin, like Material Dark, and you will see clearly which control has focus.
I think all combo boxes when focused should either get a surrounding rectangle (like Cappuccino) or a distinctive color (like Ledenets).
All check boxes should get a surrounding square when focused. The color change in some skins is attractive but not clear enough.
June 20, 2018 at 4:58 am #58067Support
KeymasterThank you for a project, I will check it soon.
July 17, 2018 at 1:07 pm #58177HeDiBo
ParticipantIn AC 13.17 the combobox now shows a focus rectangle
But the checkboxes only show a faint line at the right hand side. A full focus rectangle was what you intended, I understood. Maybe you can reexamine the source for this.
There are skins that do not need the focus rectangle. Look at Material Dark, who lights up the surrounding square in a contrasting color. A focus rectangle there would be overkill.
In other words, maybe the skins need some change.
July 17, 2018 at 3:00 pm #58181Support
KeymasterCould you show a screenshot with bad focus rectangle, please?
July 17, 2018 at 4:09 pm #58192HeDiBo
Participant'Support' wrote:Could you show a screenshot with bad focus rectangle, please?
If you run the acSetFocus project, I included, after some tabbing you will end up with this: [attachment=8838:FocusCheckBox.jpg]
Try to find where the focus is.
The problem is that check boxes without a caption are not highlighted.
The skin should be changed, to highlight the check box itself, not its possible caption.
July 17, 2018 at 4:27 pm #58197Support
KeymasterI'm not sure checkbox will have a good look in all skins in this case (if glyph is in rectangle).
Standard checkbox doesn't shows a focus rectangle at all. Maybe just do not show it if caption is empty?I was wrong, standard checkbox shows same small rectangle if caption is empty.
July 17, 2018 at 4:31 pm #58198HeDiBo
Participant'Support' wrote:Maybe just do not show it if caption is empty?
Absolutely not. That's the worst method.
Have a look at the way check boxes are highlighted in Material Dark skin. You should invent such highlight for other skins too, I think.
July 17, 2018 at 4:38 pm #58199Support
KeymasterI see what you mean, but 100+ skins must be repainted for this feature.
Standard checkboxes shows same small rectangle.
July 17, 2018 at 6:33 pm #58201HeDiBo
Participant'Support' wrote:Standard checkboxes shows same small rectangle.
That's why we choose AlphaControls.
'Support' wrote:I see what you mean, but 100+ skins must be repainted for this feature.
This is a list of skins that are already OK:
Air, AlterMetro, AlterMetro2016, AlterMetro2017, Aluminium, AutumnSky (not very pronounced though), Bejing, Bejing Ext, Black Box, Blue Shadows (a bit vague), BlueGauze (also a bit vague), Blue Glass, Blue Ice, Canvas Dark (CS), Capuccino, Clean Card (somewhat vague), Clear Sky (CS), Cold (bit vague), DarkMetro, Deep (bit vague), DeepPurple, etc. (I stopped checking because so many are already OK).
So, not 100+ skins to change…
July 28, 2018 at 10:05 pm #58249HeDiBo
ParticipantNo change in 13.18
September 19, 2018 at 11:43 am #58392HeDiBo
Participant'HeDiBo' wrote:No change in 13.18
No change in 14.01
September 21, 2018 at 9:47 am #58398Support
KeymasterSome skins have a changed checkbox already, some skins – not.
More time is needed.
September 26, 2018 at 1:17 pm #58421HeDiBo
Participant'Support' wrote:Some skins have a changed checkbox already, some skins – not.
More time is needed.
Not much improvement in 14.02
-
AuthorPosts
- You must be logged in to reply to this topic.