- This topic has 8 replies, 2 voices, and was last updated 12 years, 4 months ago by Hamilton.
-
AuthorPosts
-
May 28, 2012 at 6:12 am #35221HamiltonParticipant
Hi Serge,
Nice work on the AutumnSky skin! The only issues I've noticed are that:
1. With DevExpress v6 the selected row is not very noticable when the grid has focus. The attached screen shot shows the selection when the grid has focus and when it doesn't (it looks great with no focus). You may have done it this way by design, I'm not sure, but if it is an oversight can you please make the selection color more distinctive when the grid is focused?
2. Text is hard to read on standard dialogs using this skin because the text is black on a dark blue background. The title is white and easy to read however, it is just the body text that is difficult to read.
3. There is no mouseover animation for checkboxes.
4. TsPanels have a single white pixel in each corner. This isn't a big deal for me but some people are particular about these things so I thought I'd mention it in a gentle way 😛 You can see this in the screen shot; just above the grid is a panel you can just see the white pixel in the bottom left corner of that panel. In my app every panel has that same pixel in every corner. Please don't worry about this issue on my account, just fix it if you think other people will worry about it.
Regards,
Hamilton
June 4, 2012 at 6:05 am #48470SupportKeymasterAutumn Sky is updated now (changed color of selected row).
Quote:2. Text is hard to read on standard dialogs using this skin because the text is black on a dark blue background. The title is white and easy to read however, it is just the body text that is difficult to read.Which dialogs you meant? I see a light text in dialogs..
Quote:3. There is no mouseover animation for checkboxes.I will think how to improve that.
Quote:4. TsPanels have a single white pixel in each corner.What you mean? Can you show it, please?
June 7, 2012 at 2:08 am #48478HamiltonParticipantHi,
1. Selection color is now good when the grid has focus and when it does not have focus.
2. Dialog.png (attached) shows the black text on dark blue with a MessageDlg. The same problem exists with ShowMessage. I didn't test other dialogs.
3. Checkbox animation – TBA – looking forward to seeing what you come up with.
4. Panel.png (attached) shows a form with a TsMemo on the left, a top aligned panel and a right aligned panel with several other panels aligned within it. I've used red circles to show the dots in the screen shot. The white pixel in the corner appears to be caused by the panel being next to certain other controls – in this case the TsMemo. The panels that are inside another panel do not get white corners, the other two panels on the form do get white corners, even on the corners that are not next to the memo. In my actual application it isn't a memo causing the white corners, it is either a cxGrid or a TsPageControl, but the effect is the same.
PS This is a really nice looking skin Serge, cheers!
HTH
Regards,
Hamilton
June 15, 2012 at 7:20 am #48495SupportKeymaster'Hamilton' wrote:2. Dialog.png (attached) shows the black text on dark blue with a MessageDlg. The same problem exists with ShowMessage. I didn't test other dialogs.The TLabel component used in this dialog, you should add a support of standard controls skinning (SkinManager.SkinningRules.srThirdParty property).
Quote:3. Checkbox animation – TBA – looking forward to seeing what you come up with.This skin is updated now and have small changes, you can try.
Quote:4. Panel.png (attached) shows a form with a TsMemo on the left, a top aligned panel and a right aligned panel with several other panels aligned within it. I've used red circles to show the dots in the screen shot. The white pixel in the corner appears to be caused by the panel being next to certain other controls – in this case the TsMemo. The panels that are inside another panel do not get white corners, the other two panels on the form do get white corners, even on the corners that are not next to the memo. In my actual application it isn't a memo causing the white corners, it is either a cxGrid or a TsPageControl, but the effect is the same.These white dots are shown if form is not skinned only?
Quote:PS This is a really nice looking skin Serge, cheers!Thanks 🙂
June 18, 2012 at 7:02 am #48506HamiltonParticipantHi Serge,
I had turned off support for 3rd party controls for some reason I can't recall; turning them back on fixes the issue with the dialog text. I'll leave them on and see if there is any other side effect but nothing is apparent at first glance.
The animation for the checkbox is nice but there is an issue that after you check the checkbox the animation doesn't work any more. To repro, just put a checkbox on the form. Notice the mouseover effect. Check the checkbox, there is now no animation. Uncheck the checkbox again, there is still no animation.
I'm not sure if the white dots are visible non-skinned, I'll have to test this another time. Like I said at the start though this isn't a big issue for me but I'll do what I can to help fix it.
Regards,
Hamilton
June 23, 2012 at 8:58 am #48514SupportKeymaster'Hamilton' wrote:The animation for the checkbox is nice but there is an issue that after you check the checkbox the animation doesn't work any more. To repro, just put a checkbox on the form. Notice the mouseover effect. Check the checkbox, there is now no animation. Uncheck the checkbox again, there is still no animation.I tried it, but can't reproduce 🙁
June 25, 2012 at 7:54 am #48521HamiltonParticipantHi Serge,
Testing this with version 7.66 released on the weekend I can see that the TsCheckBox font color will change from blue to white with focus (and vice verse) but the background behind the tick does not seem to change when the TsCheckBox is checked, but it does change if the TsCheckBox is not checked. I've included picture of the 4 states (checked/not-checked with focus/no-focus) in the attached screen shot.
Comparing this with other skins, say Light Board and Office12, those other styles seem to change the border around the checkbox but not the colors in the box whereas AutumnSky seems to leave the border unchanged but draws the box colours a different shade (it also changes the font color, which the other skins don't do). It may be that the tick with the AutumnSky skin is drawing over the top of the affected region and masking the visible indicators of the state change in the box? Or maybe changing the font is enough of an indicator?
IMO having the checkbox border or color change too would be make the state clearer but if you disagree, or cannot repro, the control is functional as it stands.
Regards,
Hamilton
July 5, 2012 at 8:23 am #48559SupportKeymasterJuly 9, 2012 at 6:07 am #48593HamiltonParticipantThanks Serge, that is perfect 🙂
-
AuthorPosts
- You must be logged in to reply to this topic.