[HeDiBo]

'Support' wrote:

No, I'm using hooks for these functions (GetSysColor, GetSysCoorBrush and CreatePen), it's ready and in tests already.

Added the TsSkinManager.Options.ChangeSysColrs property.

Today evening or tomorrow I can give this new package for tests.

That's fantastic news :i-m_so_happy:

[Support]

Send me a letter, if you want, and I will answer there with attached package for tests.

[HeDiBo]

The skinning works beautifully :a3:

Some minor concerns:

I noticed some problems with some skins:

• The following skins have no contrast between highlighted text and highlighted background, making the text unreadable: DarkMetro, DarkMetro_contrast, MacOS2, Matrix, Matrix_contrast, Ubuntu, Underwater, Winter2003
• The next skins have no distinction between a normal background and a highlighted background making selection disappear: Emerald, Nautilus, Nautilus_contrast, Steam, Steam2.

You can verify both in this project: [attachment=6901:acSetSysColor.zip]

Ideally the selection should look the same as the highlight in the drop down list of the combobox.

The way you place the hook may not work in all cases. The docs say that in order to be able to use WriteProcessMemory, “The handle must have PROCESS_VM_WRITE and PROCESS_VM_OPERATION access to the process”. I'm not sure that's always true. You may have to call GetSecurityInfo and SetSecurityInfo as per this msdn article.

All in all it's a great effort already :a3:

[HeDiBo]

I've made sample screenshots of both the highlight problems and the invisible selection problems. I hope this clears things up.

[attachment=6902:acHighlightProblems.jpg]

[attachment=6903:acSelectionProblems.jpg]

[Support]

Thank you, I will update all skins soon.

[HeDiBo]

'Support' wrote:

Thank you, I will update all skins soon.

That may not be needed for the highlight problems. As you can see, the highlight in the drop down lists is OK. If the highlight in the drop down list would be the one used for the highlight in edit boxes (for all skins) only the logic of the color selection when painting the highlight needs to change, in order to use that one.

But you'll know this better. -_-

[Author]

Posts