[Lasse]

Ok, if your example code works, I will check it. I didn’t test it, my code is almost same.

[Lasse]

The issue is exactly same. I am dynamically loading the content like you did in your example code.

[Lasse]

That Bitmap property is empty in v15.00 beta…

Attachments:

You must be logged in to view attached files.

[Lasse]

Left side v14.36 and right side v15.00 beta. I just selected colors again.

• This reply was modified 4 years, 10 months ago by Lasse.

Attachments:

You must be logged in to view attached files.

[Lasse]

Oh, I just need to select colors again for the font items. No big deal. The color code is different in v15.00.

[Lasse]

I created a small demo with same kind of frames and it works. I will try to figure out what causes this.

[Lasse]

Delphi's common variable UseLatestCommonDialogs (in Vcl.Dialogs.pas) is True by default. So, it is not so wrong now but I understand that change of behaviour is not always a good thing…

[Lasse]

Well, it is a common variable, so it can be set in your program code.

[Lasse]

Oh, there is common variable acAllowLatestCommonDialogs in sDefaults.pas. By setting that to false, dialogs are fine.

[Lasse]

I noticed the same with save dialog…

[Lasse]

and the button must be TsButton, works only with TButton now…

[Lasse]

True, see the code, it tells what the problem is.

[Lasse]

Oh, that seems to be a bug in VirtualTree. Setting a property like that is not a good idea.

[Lasse]

It is. This was the first message: “When we set a TsAlphaImageList as image list of TVirtualTreeView component, it only shows grayed images and doesn't show colored images.”.

This issue happens only with virtual tree. I try to find time to create a small demo.

[Lasse]

I commented out following lines from acAlphaImageList.pas to fix this for now…

1308: //if BlendColor clNone then

1309: // ChangeBitmapPixels(Result, ChangeColorTone, acColorToRGB(BlendColor), clFuchsia);

Hmm, in my ImageList BlendColor property is clNone… it should not go there.

[Lasse]

This issue still exists in version 14.24. Random icons have color and selected icon is quite black…

[Lasse]

There is no reason to free an object if it is already nil (that would be an AV). That causes a part of that memory leak. Another part comes from the string list that is created twice.

Code:

if ColorsHolder nil then
ColorsHolder.Free;

Would make sense but ColorsHolder = nil does not… I rather use Assigned and not Assigned than nil and = nil…

[Lasse]

It might be so indeed. I will test some skins.

[Lasse]

Ok, good to know. Yes, that is perfect now.

I think it is not a good idea to have that border width as a skin option. It is ok, when you only use one skin in your application. But if you let users to choose the skin then your application borders look different and it is quite a painful to fix those borders skin by skin in code.

[Lasse]

Well, I tried that also but it is not working with MetroUI skin (see attachment). Some other skins seem to work differently. That border does not look good with status bar… TsStatusBar is slightly better thou but still that border feels too wide. I choose another skin, no problem.

[Author]

Posts