[Lasse]

I had to revert back to Delphi 11.1 (without patch 1). That is still the latest Delphi version fully working with AC.

[Lasse]

I noticed that scaling is not working with imagelists in 64-bit…

Attachments:

You must be logged in to view attached files.

[Lasse]

I haven’t noticed any errors so far.

I use now ZLib version 1.2.8 from https://www.base2ti.com/

I know it’s not the latest ZLib version but it works. It would be also possible to rip ZLib from previous Delphi version. Maybe do some comparing to the 11.2 version, find the actual “bug” from it, and report it.

Btw. there is also two other units using ZLib in AlphaSkins. I changed those too like:

acAlphaHints:

//{$IFNDEF WIN64} acZLibEx, {$ELSE} ZLib, {$ENDIF}
 ZLibEx,

acPNG.pas:

//{$IFNDEF WIN64}acZLibEx, {$ELSE}ZLib, {$ENDIF}
 ZLibEx, ZLibExApi, 

• This reply was modified 2 years, 2 months ago by Lasse.
• This reply was modified 2 years, 2 months ago by Lasse.

[Lasse]

You should add a new variable for imagelist handle and let the i variable be Integer. HIMAGELIST is the type that is used elsewhere.

[Lasse]

You can’t do anything without a source code. I am sure this will be fixed as soon as possible. The situation in Ukraine looks promising.

[Lasse]

Well, variable i is also used for loop. So, better to add other variable for imagelist handle…

[Lasse]

As a workaround before fix you can use for example https://github.com/fundamentalslib/fundamentals5/tree/master/Source/ZLib

It works on both 32-bit and 64-bit.

Just comment out current use of ZLib in sSkinManager.pas:

  //{$IFNDEF WIN64}
  //  acZLibEx,
  //{$ELSE}
  //  ZLib,
  //{$ENDIF}
  ZLibEx,

[Lasse]

This seems to be ZLib issue. AlphaSkins is using acZLibEx for 32-bit and it is working. If current ZLib is used 32-bit will break as well.

[Lasse]

Delphi 11.2 64-bit is crashing into “Stream read error” in System.Classes when skin manager tries to load skin from file. This has been working always. 32-bit build works fine… I’m not surprised at all.

[Lasse]

We will see this week what happens with version 11.2.

RAD Studio New Release: What’s Coming in 11.2

[Lasse]

Yes, I noticed that but it is not the reason.

Like I wrote before the following fixes get your AlphaSkins issues sorted out… but it is not just AC that is failing with Patch 1.

acgpUtils.pas:
748:gpaPColor := Pointer(PAnsiChar{Integer}(bmData.Scan0) + Y * bmData.Stride);

acShellCtrls.pas:
4344: // InitSystemImageList;

sGraphUtils.pas:
7506: with PRGBQuad(PAnsiChar{Integer}(srcLine) + Pixel)^ do begin

[Lasse]

And it wasn’t only AC that is broken after that. I saw random issues with other 3rd party libraries as well in 64-bit build.

Fix of these might be the reason… or not.

RSP-37760 Using ImageList causes IDE to crash
RSP-35040 64bit packets in C++ containing Delphi code do not run

Here all fixed issues in Patch 1:

RSP-37880 Can’t debug iOS
RSP-37760 Using ImageList causes IDE to crash
RSP-37733 IDE Access Violation when Inheriting from a Form with a TListView in DynamicAppearance.
RSP-37690 GridPanelLayout on form memory leaks on end app — same if not used at all
RSP-37667 Cannot fit requested classes in a single DEX file (# methods: 71471 > 65536)
RSP-37665 Code Insight broken for classic compiler
RSP-37662 Segmentation Fault(11) in SysUtils.Pop on Android64
RSP-37609 PAServer ships with Python 2.7 dependencies – which are no longer available in macOS 12.3
RSP-37408 Delayed flag break Exe’s ASLR function
RSP-37378 Memory leak
RSP-35040 64bit packets in C++ containing Delphi code do not run

• This reply was modified 2 years, 2 months ago by Lasse.

[Lasse]

Delphi 11.2 is coming soon but I don’t assume it will fix this.

[Lasse]

I think you can fix this in acDials.pas by scaling the result:

function TacDialogWnd.FixedFrame: integer;
begin
  Result := ScaleInt(ac_GetSysMetrics(SM_CXFIXEDFRAME, GetWndPPI(CtrlHandle)));
end;

[Lasse]

I assume there isn’t much updates as long as the illegal war in Ukraine lasts. Don’t hold your breath while you wait. I just hope the developer survives…

• This reply was modified 2 years, 4 months ago by Lasse.

[Lasse]

Just build debug executable. That sampling profiler will work perfectly for debug executable. Delphi version does not matter.

[Lasse]

Have you used a profiler to find out what is actually causing it?

Here is one for free: https://www.delphitools.info/samplingprofiler/

[Lasse]

I have made a lot of optimizations for AlphaSkins code and it is always possible to optimize more.

I recommend using profiling tools for your project. Here is one for free: https://www.delphitools.info/samplingprofiler/

[Lasse]

I played around a few minutes. It is not hard to get it done. Just use TRANSPARENT SkinSection and TabSkin. Underline needs a little fix to TsPageControl.DrawSkinTab. And of course you can adjust the position of the text there as well…

Since there is a war in Ukraine, I would not expect official answers soon.

• This reply was modified 2 years, 5 months ago by Lasse.

Attachments:

You must be logged in to view attached files.

[Lasse]

Reinstalling Delphi 11.1 is fast and easy, if you answer the first question NO when it asks about cleaning registry. I did it on a work machine today and it takes just a few minutes.

I assume we can wait for official answers until the war is over.

[Author]

Posts