[HeDiBo]

'Support' wrote:

Hello!

“Inherited” can't be used there anymore, because behaviour of standard code is incorrect for “RightToLeft” BidiMode.

I have sent a changed sPageControl unit via PM, please check it.

The edited pagecontrol does the trick. Thank you 👌

[HeDiBo]

'Support' wrote:

Names of these subproperties are changed in the v13.12

It's fine now

[HeDiBo]

'Support' wrote:

All skins are updated, you can try them already.

http://www.alphaskin…kins/askins.zip

Material Dark works well, Cappuccino, Cold etc. have still too little difference.

[HeDiBo]

'Support' wrote:

Thank you for the demo!

Try the AlphaControls v13.12, the error is fixed there.

Problem solved!

[HeDiBo]

'Support' wrote:

Can you show a screenshot, please?

Run my test application and select Cappuccino as skin. In AC 13.12 it should work.

[attachment=8740:acTestFB.zip]

[HeDiBo]

'Support' wrote:

Hello! All skins were updated in January.

Look the image, please. How you see lines there? If I will make it more contrast then it may be too much contrast, I think.

If you reduce your display brightness or gamma, you will see there's no difference anymore.

People who work with a display all day, will often reduce the brightness, because it prevents sore eyes.

I've made a picture to show how your image shows up on my screen:

[attachment=8737:Contrast Problem.JPG]

No difference discernible.

[HeDiBo]

'Support' wrote:

I will check and change these skins soon.

Maybe you have changed the colors, but I still cannot see much difference between odd and even rows with the skins mentioned.

Especially if the display is set to a lower intensity, the differences are not noticeable.

Did you change the skins? If so, maybe a little more difference in brightness is required.

[HeDiBo]

The PageMargins property works well.

Rafał Drzewiecki proposed to call the subproperties OffsetBottom, etc.Those names are better than just Top, Bottom, etc. Because they really are offsets.

The property PageMargins has a wrong name, in fact. If they are margins, you would expect left -4 and right -4 to decrease the margin with 4 on both sides. That doesn't happen. Because the values are really shift values i.s.o. margin values.

So, either PageMargins defines margins, or its name has to change into PageOffsets. The latter would cover the implementation nicely.

[HeDiBo]

'Support' wrote:

Thank you for the suggestion, I will try to add it too.

It's fixed. Thank you 😊

[HeDiBo]

'Support' wrote:

Hello!

Try this patched file, please.

Problem solved 👌

[HeDiBo]

'Support' wrote:

I'll try to improve it in the v13.05

Thank you for the demo.

Problem solved in 13.05

[HeDiBo]

'Support' wrote:

This is how it looks in the my editor.

[attachment=8714:Code.png]

Please, show how it looks on your side.

Sorry, I didn't mean in the Delphi editor, but in the [code}..[/code] part on this website.

[HeDiBo]

In AC 13.04 the 64 bit code changed to:

Code:

acPNG.pas.2891: MaxInSample := byte(integer(1 shl SourceBPS) – 1);
000000000084CEC9 C7C001000000 mov eax,$00000001
000000000084CECF 480FB64D27 movzx rcx,byte ptr [rbp+$27]
000000000084CED4 80E11F and cl,$1f
000000000084CED7 D3E0 shl eax,cl
000000000084CED9 80E801 sub al,$01
000000000084CEDC 884529 mov [rbp+$29],al

And that seems to work

PS. Is there anyway you can eliminate the generated tabs in the code text? They're always wrong 😰

[HeDiBo]

'Support' wrote:

Just absolute coordinates are more universal, I think.

If you need a relative offset, then you can calculate absolute coordinates with offset.

But what to do if you need to show a window in the independed coordinates on the screen?

I thought you could use the other form of the call, without the AOwnerControl. But now I understand that's not a full alternative. Thank you for enlightening me .

[HeDiBo]

'Support' wrote:

Thank you for the demo.

Really, I see that old x64 compilers has this bug.

I will search a better solution.

This solution is the best, I think (2 shl (n-1)-1), but I will check it: https://stackoverflo…on-in-delphi-xe

Thanks!

Will you report here when you think you programmed around this Delphi bug? I'll try it again then.

[HeDiBo]

'Support' wrote:

Hello!

Max value of SourceBPS is 8 there, min value is 0

I have checked the code in x32 and x64, all results were equal and there was not overflow or range errors.

Do you have problems with this code? Maybe you can give me the Png-file which can't be processed? I will test why it happens.

I didn't say there was an overflow or range error. In my 64 bit delphi (Delphi XE4) the code generated is simply wrong.

This is the stack trace:

acPNG.MulDiv16(0,0,0)

acPNG.TColorManager.RowConvertIndexed8((…),$5710618,40,128)

acPNG.TColorManager.ConvertRow((…),$5710618,40,128)

acPNG.TPNGGraphic.LoadIDAT((no value))

acPNG.TPNGGraphic.LoadFromStream($82D5BD0)

sGraphUtils.LoadBmpFromPngStream($53C8E40,$82D5BD0)

acAlphaImageList.TsAlphaImageList.GenerateStdList

acAlphaImageList.TsAlphaImageList.Loaded

System.Classes.NotifyGlobalLoading

System.Classes.InitInheritedComponent($531DEB0,TClass($6F1738))

Vcl.Forms.TCustomForm.Create($53B74E0)

Vcl.Forms.TApplication.CreateForm(TComponentClass($927278),(no value))

ac64BitBug.ac64BitBug

:00007FFCDD051FE4 ; C:WINDOWSSystem32KERNEL32.DLL

:00007FFCDD35EFC1 ;

This is a sample project, As soon as image 1 is loaded, the DIvision by Zero exception occurs.

[attachment=8702:ac64BitBug.zip]

[HeDiBo]

'Support' wrote:

AOwnerControl is an owner component for the popup window.

This control have changed WindowProc for changing of popup window if state of AOwnerControl is changed.

Also, sometimes, when state of popup window is changed then state of AOwnerControl is changed too.

If popup window is closed then AOwnerControl receives the AC_POPUPCLOSED command for additional processing if needed.

Also, popup window can use the AOwnerControl for automatic calculation of own coordinates.

So, Popup Window and AOwnerControl has synchronized behavior. AOwnerControl is a PopupCtrl in the acPopupController.pas unit, you can check it more.

Handling of the AOwnerControl is started in this line:

Code:

HandlerIndex := InitFormHandler(AForm, AOwnerControl);

Example of AOwnerControl is the TsSkinSelector component, work of popup window and combo edit is synchronized there.

Thank you for explaining it so extensively.

However I still don't understand that the ALeft and ATop parameters are not relative to the control. Because if you don't specify ALeft or ATop then the popup window IS positioned relative to the bottom of the control. If the control governs the popup window, a position relative to that control would be expected.

[HeDiBo]

Problem seems to be solved in 13.03

[HeDiBo]

Can you explain to me what the purpose is of the AOwnerControl parameter?

What's the benefit compared to the other call to ShowForm without this AOwnerControl?

[HeDiBo]

'Support' wrote:

I will check it soon.

Problem solved in 13.03

[Author]

Posts